#22940: prop224: HS revision counter should persist after service reboot ----------------------------+------------------------------------ Reporter: asn | Owner: Type: defect | Status: needs_revision Priority: Medium | Milestone: Tor: 0.3.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs prop224 | Actual Points: Parent ID: #20657 | Points: 1 Reviewer: dgoulet | Sponsor: SponsorR-can ----------------------------+------------------------------------ Changes (by dgoulet):
* status: needs_review => needs_revision * reviewer: => dgoulet Comment: * Small fix for: {{{ + log_info(LD_GENERAL, "Found rev counter for %s: %u", + b64_key_str, (unsigned) rev_counter); }}} and {{{ + log_info(LD_GENERAL, "[!] Adding rev counter %d for %s!", + (int) rev_counter, blinded_pubkey_b64); }}} I would go for using `PRIu64` instead of casting this and "possibly" reaching an overflow. I know unlikely but... The rest looks good! Solid code! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22940#comment:9> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs