#22563: Many memory pages in tor.exe for Windows violate W^X -------------------------------------------------+------------------------- Reporter: arthuredelstein | Owner: | arthuredelstein Type: defect | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: windows tor-client win32 tor-relay | Actual Points: security hardening 031-backport, | TorBrowserTeam201707R | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by arthuredelstein):
* keywords: windows tor-client win32 tor-relay security hardening 031-backport, TorBrowserTeam201707 => windows tor-client win32 tor-relay security hardening 031-backport, TorBrowserTeam201707R * status: needs_revision => needs_review Comment: Replying to [comment:7 gk]: > We are not using `rbm` for the alphas yet. Thus, we'd need a `Gitian` patch. Yes, giving what amounts to a compiler change some testing in our nightly/alpha builds first sounds like a good idea. > Moreover, it seems we get 7c90d5921bd2cb678eec09d05b10ce6fd13463bc as well with this mingw-w64 bump which allows us to get rid of one of our tor-browser patches I think. We should test that, too, while we are at it. Thanks for pointing that out. Here's a gitian patch and the corresponding tor-browser.git patch: https://github.com/arthuredelstein/tor-browser-bundle/commit/22563 https://github.com/arthuredelstein/tor-browser/commit/22563 But if we transition to rbm first, we can also use these two patches instead: https://github.com/arthuredelstein/tor-browser-build/commit/22563 https://github.com/arthuredelstein/tor-browser/commit/22563 Note I have had some trouble building the gitian build, but I will try again today. I'm pretty confident it will work as the rbm build worked for me. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22563#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs