#22779: choose_good_entry_server() is no longer used to choose entry guards ---------------------------------------+----------------------------------- Reporter: teor | Owner: nickm Type: defect | Status: accepted Priority: Medium | Milestone: Tor: | 0.3.1.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.0.1-alpha Severity: Normal | Resolution: Keywords: maybe-030-backport guards | Actual Points: .1 Parent ID: | Points: 0.5 Reviewer: | Sponsor: SponsorV ---------------------------------------+----------------------------------- Changes (by nickm):
* keywords: maybe-030-backport => maybe-030-backport guards * sponsor: => SponsorV * actualpoints: => .1 Comment: Replying to [ticket:22779 teor]: > choose_good_entry_server() says: > {{{ > * If <b>state</b> is NULL, we're choosing a router to serve as an entry > * guard, not for any particular circuit. > }}} > > But in 0.3.0 and later, we use guardsets to choose entry guards. > (And we use this function to choose individual entries.) > > We should: > * fix the comment, > * check for NULL state (and do what?), and > * make sure that guard selection and entry selection doesn't get out of sync. (I think we're ok here, but I don't understand the new guard code very well.) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22779#comment:2> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs