#22343: Save as... in the context menu results in using the catch-all circuit -------------------------------------------------+------------------------- Reporter: gk | Owner: | arthuredelstein Type: defect | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Major | Resolution: Keywords: tbb-linkability, ff52-esr, | Actual Points: tbb-7.0-must, tbb-7.0-issues, tbb-regression, | tbb-7.0-frequent, TorBrowserTeam201708R | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by mcs): Good work on a complicated fix! After reviewing the patch and testing it a little on OSX, Kathy and I have a couple of comments: - Consider changing the UUID for `embedding/components/webbrowserpersist/nsIWebBrowserPersist.idl` - Please add documentation for `persistArgs.loadingPrincipal` to the block comment before the implementation of `internalPersist()`. - Code inside `browser/base/content/pageinfo/pageInfo.js` makes a call to `internalSave()` but you did not add the content principal parameter there. Is that intentional or is it an oversight? And is there another ticket about saving media from page info using the catch all circuit. - `Save Image As` is still not working for us. about:downloads shows "Failed" and Kathy and I see the following on the browser console: {{{ 15:14:58.300 [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebBrowserPersist.savePrivacyAwareURI]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/contentAreaUtils.js :: internalPersist :: line 580" data: no] 1 (unknown) internalPersist chrome://global/content/contentAreaUtils.js:580:5 continueSave chrome://global/content/contentAreaUtils.js:489:5 internalSave/< chrome://global/content/contentAreaUtils.js:451:7 Handler.prototype.process resource://gre/modules/Promise- backend.js:932:23 this.PromiseWalker.walkerLoop resource://gre/modules/Promise- backend.js:813:7 bound self-hosted:913:17 bound bound self-hosted:913:17 this.PromiseWalker.scheduleWalkerLoop/< resource://gre/modules /Promise-backend.js:747:11 }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22343#comment:21> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs