#22805: Remove or_circuit_t.is_first_hop, because it's not accurate any more -------------------------------------------------+------------------------- Reporter: teor | Owner: nickm Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt, security-review, | Actual Points: .3 review-group-23 | Parent ID: | Points: 1 Reviewer: asn | Sponsor: -------------------------------------------------+-------------------------
Comment (by asn): `282696e7b9` is an interesting change. Do we care about false positives and are they possible? Could we accidentally mark a channel as client if `connection_or_digest_is_known_relay()` returns false because we have a consensus desynch (too old/new consensus)? I'm mainly concerned about `channel_get_for_extend()` skipping `is_client` channels, so if false positives are possible we should think if we care here. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22805#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs