#23564: run make check-changes in CI -----------------------------------+------------------------------------ Reporter: catalyst | Owner: nickm Type: task | Status: needs_revision Priority: Medium | Milestone: Tor: 0.3.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: ci tor-doc tor-releng | Actual Points: Parent ID: #23562 | Points: Reviewer: | Sponsor: -----------------------------------+------------------------------------ Changes (by catalyst):
* status: needs_review => needs_revision Comment: It looks like a good start! Seems to produce false negatives if `$(top_srcdir)` is, say, `.`. The dotfile check probably should be against `os.path.basename(f)` and should probably be in the `__main__` clause. The file walk seems like it might only go one level deep; this is probably OK if we document it, otherwise consider using something like `os.walk()`? Also, typo ("Ticked" vs "Ticket"): {{{ - warn("bugfix does not say 'Fixes bug XXX'") + warn("Ticked marked as bugfix, but does not say 'Fixes bug XXX'") }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23564#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs