#24509: circuit_can_use_tap() should only allow TAP for v2 onion services -------------------------------------------------+------------------------- Reporter: teor | Owner: (none) Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.3.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.2.1-alpha Severity: Normal | Resolution: Keywords: prop224, tor-hs, security-low, | Actual Points: easy, intro | Parent ID: | Points: 0.5 Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by irl):
* status: needs_revision => needs_review Comment: Ok, so testing now instead for the presence of the version specific object on the `origin_circuit_t`. If this patch is now doing the right thing, I'd like to go back and add those comments to the `rend_data` in `origin_circuit_t` to avoid any confusion on that in the future too. This test may be too strict, would `rend_data` ever be defined for v3 services? Looking at the definitions all the data stored appears to be specific to v2 in `rend_data`. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24509#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs