#22084: Neuter NetworkInformation API on Tor Browser Mobile
-------------------------------------------------+-------------------------
Reporter: gk | Owner: igt0
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile tbb-fingerprinting, | Actual Points:
TorBrowserTeam201712 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by igt0):
Thanks,
I attached the back ported patches following the proposed workflow:
Part 1:
https://trac.torproject.org/projects/tor/attachment/ticket/22084/0001
-PATCH-Bug-1372072-Part-1-Spoofing-network-informatio.patch
Part 2:
https://trac.torproject.org/projects/tor/attachment/ticket/22084/0002
-PATCH-Bug-1372072-Part-2-Add-a-test-case-for-check-w.patch
Replying to [comment:10 gk]:
> Thanks. I think the code backported looks good. However, I think we
should have a better patch format. First, we should keep the Mozilla bug
number. That makes it easier to find the patch(es) in our tree. Second, we
should keep the patch(set) structure: one commit in our tree should match
one commit taken from Mozilla. This allows us to pinpoint possible issues
easier. Third, we should fix up the commit message if needed (in your case
you still have included "This tests not only windows, but also workers."
even though you rightly omitted the workers related part).
>
> A workflow that works fine for me is having `mozilla-central` as a git
remote and cherry picking the patches from that one into `tor-browser`
one-by-one, fixing them up if needed and adapting the commit message
afterwards with `git commit --amend` if needed as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22084#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
