#24175: Use an embedded Jetty in metrics-web and use metrics-base as build environment. -----------------------------+-------------------------------- Reporter: iwakeh | Owner: iwakeh Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Component: Metrics/Website | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------+--------------------------------
Comment (by iwakeh): Replying to [comment:9 karsten]: > Thanks for splitting up that huge commit. These smaller commits are much easier to review! Good, that this worked for you! > > I made it through commits 8627a0a to 6b54501 in your task-24175-stepbystep branch and have a few remarks: > > - In e9b4bb5 you're moving the users-q-and-a.txt file, but you're not updating links in metrics.json. That's going to produce a couple dead links. Ergh, forgot to adapt these links. > - Commit 9a80a5b says it's a fixup for b17c1bf, but I believe it's rather a fixup for 2f5fd6f. And I believe it's an incomplete fixup commit, leaving some accidentally made changes unchanged. I haven't checked in detail. Please, continue the check. The diffs I checked before committing seemed fine, but you've made many of the changes in the concerned files. > > Those are the only findings from reading the diff. I might discover more issues while testing. > > How do we proceed? Do you mind if I make these remaining fixes while rebasing your branch to master? I'd then share the rebased branch here while testing it locally. No objection. The new modules in the old style were not yet merged. So, this should work. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24175#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs