#21847: Update copy for security slider to be consistent with the mobile experience -------------------------------------------------+------------------------- Reporter: isabela | Owner: tbb- | team Type: enhancement | Status: closed Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: fixed Keywords: tbb-usability, tbb-security-slider, | Actual Points: TorBrowserTeam201712R, GeorgKoppen201712 | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by gk):
* status: needs_review => closed * resolution: => fixed Comment: Replying to [comment:16 mcs]: > The followup patch looks good to me. > I did notice a small issue today when I ran with the new code on macOS: when the Security Settings window first opens, nthe "Learn More" link has the keyboard focus. I suppose that is just default XUL behavior (set focus to the first element that can have a keyboard focus), but it looks a little strange because macOS draws a box around the link. If you think this is worth fixing, the following addition to `torbutton_init_security_ui()` fixes it: > {{{ > let okBtn = document.documentElement.getButton("accept"); > if (okBtn) > okBtn.focus(); Thanks, this is included in commit 0e9fe510277aeb8617f9de73d24b85436479f129 on `master` now. The follow-up ticket for getting the improvements made here back to mobile is #24653. > }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21847#comment:17> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs