#24733: Loading ifc.ifc_buf using the new tor_free() causes undefined behaviour
on
x86_64 macOS
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: address-sanitizer, unexpected- | Actual Points: 0.1
consequences, review-group-28 |
Parent ID: | Points: 0.1
Reviewer: | Sponsor:
| Sponsor8-can
-------------------------------------------------+-------------------------
Comment (by catalyst):
Another approach is making a special (static) free function that takes a
pointer to `struct ifconf` and accesses `ifc->ifc_buf` directly. We could
add comments there explaining why it's necessary (which also avoids
cluttering the main body of `get_interface_addresses_ioctl()`).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24733#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
