#24996: OnionPerf showing >200% timeouts --------------------------------+------------------------------ Reporter: irl | Owner: karsten Type: defect | Status: needs_review Priority: Medium | Milestone: Component: Metrics/Statistics | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------+------------------------------ Changes (by karsten):
* status: accepted => needs_review Comment: It looks like we implemented the database query for filling the `"requests"` column in the [https://metrics.torproject.org/stats/torperf-1.1.csv underlying CSV file] as '''completed requests''' and later used the data in the graph as if it contained '''total requests made'''. The latter definition is also what we wrote in the [https://metrics.torproject.org/stats.html#torperf-1.1 specification], so I'd say let's change the database query. At least I can't come up with a good reason for keeping the current implementation. Please review [https://gitweb.torproject.org/karsten/metrics- web.git/commit/?h=task-24996&id=034008835fecd498180d5aba31500b1fd7013129 commit 0340088 in my task-24996 branch] with a small fix. If that looks okay, I can deploy it easily on the server, and the next module run will fix the CSV file and graph. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24996#comment:2> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs