#25013: Move TorButton code to the tor browser repository --------------------------------------+-------------------------------- Reporter: igt0 | Owner: tbb-team Type: defect | Status: needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201803R | Actual Points: Parent ID: #24855 | Points: Reviewer: gk, sysrqb, mcs, | Sponsor: --------------------------------------+-------------------------------- Changes (by arthuredelstein):
* status: needs_review => needs_revision Comment: Replying to [comment:20 igt0]: > I followed the same approach in the #25260, torbutton will work as a feature extension, so we still need to change the browser adding it as a subdirectory(git submodule?). Hi, Igor -- do you think torbutton could continue to be built independently inside the torbutton.git repo, and then copied as an .xpi into the Tor Browser Bundle by tor-browser-build.git? I'm wondering if can avoid adding the gecko build infrastructure. > The changes in the tor button are related to the build system and making it work with the mozilla central code base(few things changed and others are deprecated). > > **bug 25013: Add Gecko build system infrastructure into tor button** > https://github.com/igortoliveira/torbutton/commit/ef153a43363ee0714f6187b545494161bea96610 > > **bug 25013: Migrate general.useragent.locale to intl.locale.requested ** > https://github.com/igortoliveira/torbutton/commit/40682676e33570d464534adc07bf94acb36a76fe > > **bug 25013: Update deprecated JS code** > https://github.com/igortoliveira/torbutton/commit/1b50773f87465643ab8aed8104fa0c9a0fa5e0f5 > > **bug 25013: Update XPCOM calls after changes in the interfaces** > https://github.com/igortoliveira/torbutton/commit/a35a746ca206706f4c5742d70bc90b649c1bfdf0 I posted some comments on github. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:23> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs