#23854: Add an RSS feed for https://metrics.torproject.org/news.html -----------------------------+-------------------------------- Reporter: cypherpunks | Owner: irl Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Component: Metrics/Website | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------+-------------------------------- Changes (by karsten):
* status: needs_review => needs_revision Comment: Alright, I did a first review by reading commits without trying them out yet. Here's what I found: - You should read about "Java diamond operator". In several places you're undoing changes that we made quite recently when switching to Java 7. For example, we prefer `List<String> aList = new ArrayList<>();` over `List<String> aList = new ArrayList<String>();'. - Please add a space after the closing bracket in `return (String[]) this.protocols.toArray()` and related places. - I think your code prints a news entry with `start == end` as "start to end", whereas the current code would print it as just "start". Can you change that back? - You picked non-standard Java variable names like `short_desc` and fixed them in a later commit. Can you rather make such fixes to your own commits as "fixup" or "squash" commits and either squash them yourself or let me do that as part of the merge process? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23854#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs