#25386: fix rust tests -------------------------------------------------+------------------------- Reporter: Hello71 | Owner: Hello71 Type: defect | Status: | merge_ready Priority: High | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.3.1-alpha Severity: Normal | Resolution: Keywords: rust, tor-test, 033-backport, | Actual Points: review-group-34 | Parent ID: | Points: 3 Reviewer: isis | Sponsor: | Sponsor8-can -------------------------------------------------+------------------------- Changes (by isis):
* status: needs_review => merge_ready Comment: Hi, this looks great! Thanks! Just one tiny thing: when you squash, please remove commit f7b714ba411eb7ccdfcafe676df28f81bb823b57, as it breaks out-of-directory builds. (It should be `$abs_top_srcdir` in that line, since the test_rust.sh script doesn't get copied to the build dir.) I added a commit on top in my `bug25386_v2` branch, which changed the test you added to actually check the functionality of `protover::compute_for_old_tor`, and found a bug (#XXX), so this is pretty cool. I recommend merging whenever Hello71 squashes, and then I'll put the tests I made/changed in #XXX. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:21> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs