#24031: Protover.rs could use a better algorithm -------------------------------------------------+------------------------- Reporter: nickm | Owner: isis Type: defect | Status: | needs_review Priority: Very High | Milestone: Tor: | 0.3.3.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.3.1-alpha Severity: Normal | Resolution: Keywords: rust, 033-must, protover, security, | Actual Points: 5 033-triage-20180326, 033-included-20180326 | Parent ID: | Points: 1 Reviewer: nickm | Sponsor: | SponsorM-can -------------------------------------------------+-------------------------
Comment (by isis): Replying to [comment:17 isis]: > Do you think it might read better if I refactored setting `supported` to be like this? > > {{{#!rust > let supported: &str = supported_cstr.to_str().unwrap_or(""); > }}} I think this is easier, and it's also shorter? I added it to my `bug24031_r4` branch in commit `8614ec7b5`. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24031#comment:18> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs