#25126: about:tor should work on small screens (mobile) -------------------------------------------------+------------------------- Reporter: igt0 | Owner: tbb- | team Type: enhancement | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-torbutton, | Actual Points: TorBrowserTeam201804R | Parent ID: #24855 | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by gk): Replying to [comment:15 igt0]: > Replying to [comment:14 mcs]: > > This looks good, except we found one additional problem: using a fixed size for the `bubble` elements does not work for all languages. We tested by setting `general.useragent.locale` to `de` and found that the text extended below the bubble background. Kathy and I removed the height rule and that seemed to fix the problem, but maybe there is a better solution. > > > > In fact I think it is a good solution, thus the height of the higher bubble item will define the height of the parent element. I gave a try and tested in different languages and screen size, and looks good. > > > Also, please update the year within the copyright notice of both files. > > nice catch, thanks. > > Updated code: > > **bug 25126: Make about:tor layout responsive** > https://github.com/igortoliveira/torbutton/commit/bcc6dc11e5c9bed40ffe976ab93ec6da17ee33ea I get merge conflicts for some reason. Could you rebase your patch on latest `master`. Please use a new branch for that, thanks. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25126#comment:18> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs