#25400: CIRC_BW event miscounts, should count all circ data -------------------------------------------------+------------------------- Reporter: mikeperry | Owner: | mikeperry Type: defect | Status: | merge_ready Priority: Medium | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-stats, review-group-34, 034 | Actual Points: -roadmap-subtask, 034-triage-20180328, | 034-included-20180328 | Parent ID: #25546 | Points: Reviewer: dgoulet | Sponsor: -------------------------------------------------+------------------------- Changes (by dgoulet):
* status: needs_review => merge_ready Comment: Good stuff! Your top fixup commit that uses `tor_add_u32_nowrap()` won't squash cleanly since that function is added in its own commit so you might want to either do a new commit or base it on that helper function commit. Happy with the fixups! lgtm; -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25400#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs