#25980: Orfox bustage on tor-browser-52.7.3esr-8.0-1 --------------------------------------+------------------------------ Reporter: sysrqb | Owner: tbb-team Type: defect | Status: needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-mobile | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------+------------------------------ Changes (by sysrqb):
* status: new => needs_review Comment: Okay, easy fix. On Android, the NDK (from LLVM) defines `__libc_feof(FILE*)` as a wrapper around `feof(FILE*)`. Mozilla redefined `feof` as `feof(hnjFile*)`, this caused a type mismatch because `__libc_feof(FILE* f)` then called `feof(f)` but `f` was the wrong type (FILE*, instead of hnjFile*). We can redefine `__libc_feof` the same way Mozilla redefined `feof` - using a C++ preprocessor. The guards around the #define aren't strictly necessary, but I didn't want to introduce unnecessary changes on other platforms. We can delete them if that's preferred. Branch bug25980 https://git.torproject.org/user/sysrqb/tor-browser.git -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25980#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs