#26008: Make workqueue cancel code always get covered by tests. -------------------------------------------------+------------------------- Reporter: nickm | Owner: nickm Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-ci, tor-tests-coverage, tor- | Actual Points: tests-unit | Parent ID: #25908 | Points: Reviewer: | Sponsor: | Sponsor3-can -------------------------------------------------+------------------------- Changes (by nickm):
* status: accepted => needs_review Comment: FWICT, this was happening because of a really improbable PRNG output in test_workqueue_cancel.sh. In any case, I found a place where I was using a truly broken reservoir sampling algorithm in test_workqueue.c, and replaced it with a better one that should avoid this outcome. See branch `ticket26008`, with PR at https://github.com/torproject/tor/pull/89 -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26008#comment:2> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs