#17873: replacing 0.0.0.0 listeners at runtime fails --------------------------------------------+------------------------------ Reporter: cypherpunks | Owner: (none) Type: defect | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-client port bind switching | Actual Points: Parent ID: | Points: Reviewer: ahf | Sponsor: --------------------------------------------+------------------------------ Changes (by ahf):
* status: needs_review => needs_revision Comment: Please create a PR since reviewing this seems impossible with GH's UI otherwise. A few comments here: - I think the style with using `if (x) foo = bar` on the same line is uncommon on the Tor source code. Please move the assignment to its own line. - Shouldn't we lift `replacement_s` out of the .c file or at least document it since it's referred to in the doc strings? A typedef to get rid of the 'struct' might also be a good idea. - In `replacement->new_port = (port_cfg_t *)wanted;` where constness is removed? Do we actually need to remove the constness here, or? Maybe the loop could be made non-const if we need to? - Have this been tested on any other platforms than Windows and Linux? Maybe FreeBSD & OpenBSD could have `ENABLE_LISTENER_REBIND` too? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17873#comment:24> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs