#26032: suggestion URL is broken (duplicate [[]]) --------------------------------+------------------------------ Reporter: cypherpunks | Owner: iwakeh Type: defect | Status: needs_review Priority: Medium | Milestone: Component: Metrics/ExoneraTor | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------+------------------------------ Changes (by iwakeh):
* cc: metrics-team (added) * status: accepted => needs_review Comment: It seems the database query supplies some (or all; I didn't check the productive db) ipv6 addresses surrounded by brackets, but ExoneraTorServlet expects ipv6 addresses from the db to be without brackets, which causes the error. Please review [https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-26032 this patch] adding a test with various possible inputs and removing all superfluous brackets when creating suggestion links. Of course, the removal of brackets could also be placed elsewhere, for example into QueryResult, but the above patch puts this functionality close to the suggestion link generation, because this seems to be the only affected place. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26032#comment:2> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs