#25750: update Tor Launcher for ESR 60 --------------------------------------------+------------------------------ Reporter: mcs | Owner: brade Type: defect | Status: | needs_revision Priority: Very High | Milestone: Component: Applications/Tor Launcher | Version: Severity: Normal | Resolution: Keywords: ff60-esr, TorBrowserTeam201805 | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------------+------------------------------
Comment (by sysrqb): Replying to [comment:20 mcs]: > Replying to [comment:19 igt0]: > > I took a quick look in the code and I have a question about d104e7ecd35b2dbd38cdc9988fbd5924857d857d, does it load all the default properties every time the browser is restarted? > > Yes, I think so. Do you think that is a problem? I suspect that is what the code that Mozilla removed did too. Yes, that was my understanding. > > If addressing this for Torbutton is really messy, maybe we should put more effort into reverting the Mozilla patch that removed support for default preferences (doing so would fix #26039 as well). But I defer to Matt who already tried that approach. Basically, after Mozilla removed this functionality, they simplified the remaining code (inlining other functions because now they only have a single call site, deleting and refactoring other functions). From what I saw, as I began reverting the commit and integrating the code into the current logic, it was a bit complicated - so I decided implementing the loading in the extension was much, much easier. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25750#comment:22> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs