#26022: Fix a flaw in the noise-removing code in our onion service statistics --------------------------------+------------------------- Reporter: karsten | Owner: karsten Type: defect | Status: closed Priority: High | Milestone: Component: Metrics/Statistics | Version: Severity: Normal | Resolution: fixed Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------+------------------------- Changes (by karsten):
* status: merge_ready => closed * resolution: => fixed Comment: Replying to [comment:20 iwakeh]: > Replying to [comment:18 karsten]: > > Please review commits [https://gitweb.torproject.org/karsten/metrics- web.git/commit/?h=task-26022&id=d297e80ba990f0163018e5ce5b2d9d131d9a1fb3 d297e80] and [https://gitweb.torproject.org/karsten/metrics- web.git/commit/?h=task-26022&id=4a518a29306e6c372b207fc172dc82b1956c28ec 4a518a2] in [https://gitweb.torproject.org/karsten/metrics- web.git/log/?h=task-26022 my task-26022 branch]. > > Both commits are fine, pass tests and checks. Great! Merged and deployed. > I think there are other places in Metrics' code where rounding is performed implicitly by relying on integer operations. These should be looked for and also be replaced by explicit rounding. Maybe, a new ticket? I don't think that we have a similar issue in another part of metrics-web. After all, this only affects negative numbers, and we typically work with positive numbers. I also think I would have spotted such a case when specifying how we're processing data in metrics-web a few weeks ago. Closing. Thanks again! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26022#comment:21> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs