#26073: patch tor-browser-build.git for Firefox 60 ESR --------------------------------------------+------------------------------ Reporter: arthuredelstein | Owner: tbb-team Type: defect | Status: needs_review Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201805, ff60-esr | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------------+------------------------------
Comment (by boklm): Some comments on `bug-26073-rev1`: 6d3afa069c3904b5319b2cfd5e3f9aca45516ea7 (Use cairgo-gtk3 and provide libgtk-3-dev for Firefox 60 ESR) did you check if `libgtk2.0-dev` is still needed? If not, we could remove it. 4dc04f54801b6a535a4935af10d42a939086dae5 (Use a more recent version of gcc) What is the reason for using a more recent version of gcc to build LLVM? If it is because of the LLVM update in the previous commit (61af9560529c3424e), maybe it should be merged with that commit. Or maybe the llvm update could be separated from the previous commit in a new commit named `update LLVM` which would also use the newer gcc in the LLVM build. If you take the patch from #26165 in your branch, the lines added to `projects/llvm/build` to use a more recent version of gcc can be replaced by: {{{ [% pc('gcc', 'var/setup', { compiler_tarfile => c('input_files_by_name/gcc') }) %] # We need a link to our GCC, otherwise the system cc gets used which points to # /usr/bin/gcc. ln -s gcc /var/tmp/dist/gcc/bin/cc }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:34> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs