#26204: Bundle d3dcompiler_47.dll for Tor Browser 8 --------------------------------------------+------------------------------ Reporter: gk | Owner: tbb-team Type: defect | Status: | needs_revision Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: ff60-esr, TorBrowserTeam201805 | Actual Points: Parent ID: #26203 | Points: Reviewer: | Sponsor: --------------------------------------------+------------------------------
Comment (by boklm): Replying to [comment:4 sukhbir]: > Replying to [comment:3 boklm]: > > Thanks for the review! > > > The patch looks good to me, although I did not try to build the firefox part. > > > > However I think we are missing the part where we copy the `d3dcompiler_47.dll` file to the bundle (I think in `$distdir/Browser`). > > I added it by setting `fxcdir` and copying the `dll`. Is that fine or can we do better? This looks good. If you set `fxcdir` before setting `PATH`, you can use it while seting `PATH`. An other thing I noticed while looking at the patch again: in `projects/fxc2/build` you can replace `/var/tmp/dist/fxc2/bin/` in the 3 lines it is used by `"$distdir/bin/"`. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26204#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs