#26227: Review existing stem.client code ---------------------------+------------------------------ Reporter: dmr | Owner: dmr Type: task | Status: needs_review Priority: Medium | Milestone: Component: Core Tor/Stem | Version: Severity: Normal | Resolution: Keywords: client | Actual Points: Parent ID: | Points: Reviewer: atagar | Sponsor: ---------------------------+------------------------------
Comment (by atagar): > LinkProtocol __eq__, future direction Sure. All attributes of the LinkProtocol are derived from its integer version, so it would be perfectly fine to do equality and hash on that. > do you envision we might turn it into something beyond a NamedTuple in the future, for version-specific behavior? Good question. I don't have any plans to extend it at present but I'd be happy to chat if you think it would be useful to do so. > I also saw a change to the circ_id allocation algorithm. If you the LinkProtocol addition then nope, I didn't change it. Just moved it. The part that concerns us is a [https://gitweb.torproject.org/torspec.git/tree/tor- spec.txt?id=4df184021b7c84cc47e2ed19a601b1e790b5b4fb#n930 few paragraphs later]... {{{ With protocol version 3 or lower, a client with no public key MAY choose any CircID it wishes, since clients never need to process a CREATE cell. In link protocol version 4 or higher, whichever node initiated the connection sets its MSB to 1, and whichever node didn't initiate the connection sets its MSB to 0. }}} > I really liked 84e4e657b4785e4888e567fbc04c8ea29fd43cc4 - I was contemplating how we might do that, and having an unused attribute makes a lot of sense! Neat, glad ya like it! > Do you think it might make more sense to call it padding, though? Actually, initially I did call it that until I realized the name conflicted with PADDING and VPADDING cells. I kinda like the name 'unused' since it makes it clear that it's bytes that have no impact. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26227#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs