#26398: feature gate testing C code from Rust for now ----------------------------------------------+---------------------------- Reporter: isis | Owner: isis Type: defect | Status: | merge_ready Priority: Very High | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.3.1-alpha Severity: Normal | Resolution: Keywords: rust, tor-test, fast-fix, tor-ci | Actual Points: Parent ID: | Points: 1 Reviewer: | Sponsor: | Sponsor8-can ----------------------------------------------+----------------------------
Comment (by isis): Replying to [comment:5 teor]: > Replying to [comment:4 nickm]: > > Isis, Catalyst: Do you still think we should merge this? > > I think I'll need it for the PrivCount noise branch. Or did we fix the linker issues? Looking at the current status of #25386 it seems there's still going to be linker issues, particularly from doctests, for the time being until everything has rustc 1.27 stable (when the `-C` option [https://github.com /rust- lang/rust/pull/49956/commits/1a0d7a8207907e2459db8df72a8f604cdcc8285f was added] to rustdoc). It might be good to have a configurable way to disable this stuff until all the issues are resolved, that way teor and I can continue writing tests as we would normally for now. In the future, it also gives us an easier way to enable running the tests all the time, when we remove C code (e.g. if I were to write a sha2 or keccak implementation and we used that instead of the C code). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26398#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs