#18342: Provide more accurate reverse DNS results -----------------------------+-------------------------------- Reporter: cypherpunks | Owner: irl Type: defect | Status: needs_revision Priority: Medium | Milestone: Component: Metrics/Onionoo | Version: Severity: Normal | Resolution: Keywords: metrics-2018 | Actual Points: Parent ID: | Points: Reviewer: karsten | Sponsor: -----------------------------+-------------------------------- Changes (by karsten):
* status: needs_review => needs_revision Comment: Replying to [comment:26 irl]: > I have updated the specification patch in my metrics-web branch [[https://gitweb.torproject.org/user/irl/metrics- web.git/log/?h=task/18342|task/18342]]. A few comments: - In the protocol version summary: ''"Added '''~~a~~''' new optional X and Y field'''s'''''". Unless the current text is correct English. To me it reads as if the Y part came in later and the rest of the sentence stayed the same. - For the deprecated field and the two newly added field, please include a date when they will be removed or have been added, respectively. Git history contains some examples. - The specification of `"unverified_host_names"` does not make it entirely clear whether a host name can show up in both newly added fields. It's the "regardless" part that threw me off. Maybe there's a way to make this clearer? > I do not yet have a repository to push to on git.tpo, but to avoid blocking on this (#26643) I have pushed my Onionoo branch to GitHub and opened a [[https://github.com/irl/onionoo/pull/1|pull request]] against master which should allow for review. I took the opportunity and used GitHub's review capabilities. Please take a look there. Great stuff! Really looking forward to merging this soon. Setting to needs_revision for now. Thanks! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18342#comment:28> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs