#23576: Make service_intro_point_new() take a node instead of an extend_info -------------------------------------------------+------------------------- Reporter: teor | Owner: teor Type: defect | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.3.5.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.2.1-alpha Severity: Normal | Resolution: Keywords: prop224, tor-hs, single-onion, | Actual Points: ipv6, 034-triage-20180328, | 034-removed-20180328, fast-fix | Parent ID: #23493 | Points: 1 Reviewer: asn | Sponsor: -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_review => needs_revision Comment: This looks good and I like the code simplification! I left a few nitpicks on the PR that you might want to handle. Also, should we try to rebase this so that we can see the appveyor green checkmark (now that #26986 got fixed)? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23576#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs