#24796: Review all requested and required Android permissions
----------------------------------------------+----------------------------
Reporter: sysrqb | Owner: tbb-team
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TorBrowserTeam201808 | Actual Points:
Parent ID: #26531 | Points:
Reviewer: | Sponsor:
----------------------------------------------+----------------------------
Comment (by sysrqb):
Replying to [comment:13 gk]:
> 3) The first part of the patch is
> that's not aligned (`ACCESS_NETWORK_STATE` is treated differently).
Note, after excluding ACCESS_NETWORK_STATE, the app now crashes because it
assumes it has that permission unconditionally. I think we can keep this
for the first alpha, and consider refactoring the affected code and
exclude the permission in a later alpha. #27217
{{{
--------- beginning of crash
08-20 12:01:14.662 26467 26467 E AndroidRuntime: FATAL EXCEPTION: main
08-20 12:01:14.662 26467 26467 E AndroidRuntime: Process:
org.torproject.torbrowser_24796, PID: 26467
08-20 12:01:14.662 26467 26467 E AndroidRuntime:
java.lang.SecurityException: ConnectivityService: Neither user 10152 nor
current process has android.permission.ACCESS_NETWORK_STATE.
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
android.os.Parcel.readException(Parcel.java:2005)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
android.os.Parcel.readException(Parcel.java:1951)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
android.net.IConnectivityManager$Stub$Proxy.getActiveNetworkInfo(IConnectivityManager.java:1195)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
android.net.ConnectivityManager.getActiveNetworkInfo(ConnectivityManager.java:786)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
org.mozilla.gecko.util.NetworkUtils.getConnectionType(NetworkUtils.java:123)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
org.mozilla.gecko.util.NetworkUtils.isWifi(NetworkUtils.java:115)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
org.mozilla.gecko.activitystream.homepanel.stream.StreamOverridablePageIconLayout.updateIcon(StreamOverridablePageIconLayout.java:92)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
org.mozilla.gecko.activitystream.homepanel.stream.WebpageItemRow.bind(WebpageItemRow.java:85)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
org.mozilla.gecko.activitystream.homepanel.StreamRecyclerAdapter.onBindViewHolder(StreamRecyclerAdapter.java:202)
08-20 12:01:14.662 26467 26467 E AndroidRuntime: at
org.mozilla.gecko.activitystream.homepanel.StreamRecyclerAdapter.onBindViewHolder(StreamRecyclerAdapter.java:51)
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24796#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
