#25573: Track half-closed stream IDs ------------------------------------------------+-------------------------- Reporter: mikeperry | Owner: (none) Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: guard-discovery-stats 034-backport | Actual Points: Parent ID: #25574 | Points: Reviewer: teor | Sponsor: | SponsorV-can ------------------------------------------------+-------------------------- Changes (by mikeperry):
* status: needs_revision => needs_review Comment: Ok the following fixups have been pushed to mikeperry/ticket25573-v2: The space is fixed in c2dbb09dc3e4ed2b9d5a845a592a2d59d2d5e225. Using bsearch in get_unique_stream_id_by_circ() is fixed in 99153878cb4b7ae309eb7f5109747e3a49ac00e9. Tests for stream id wrapping and other get_unique_stream_id_by_circ() cases are in b8ae08caa059dc8f937a4afe9f929035b8beb712. I have pushed a cleanly reorganized and squashed branch to mikeperry/ticket25573-v2-squashed2 (aka https://github.com/torproject/tor/pull/296). Its has 0 delta to mikeperry/ticket25573-v2, and everything has been squashed into 4 commits (a const for smartlist_bsearch; all half-stream tracking code+tests; prevent stream-id reuse code+tests; and truncate accounting code+tests). Only the last two commits change client behavior. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25573#comment:17> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs