#27097: Add "Tor News" newsletter signup link in Tor Browser -------------------------------------------------+------------------------- Reporter: arthuredelstein | Owner: tbb- | team Type: defect | Status: | needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: ux-team, tbb-fundraising, | Actual Points: TorBrowserTeam201809, tbb-8.0.1-can | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by gk):
* keywords: ux-team, tbb-fundraising, TorBrowserTeam201809R, tbb-8.0.1-can => ux-team, tbb-fundraising, TorBrowserTeam201809, tbb-8.0.1-can * status: needs_review => needs_revision Comment: Looks good! One small thing: {{{ + const kAboutTorHideTorNewsBanner = this.kAboutTorHideTorNewsBanner; }}} just remove that line and use `this.kAboutTorHideTorNewsBanner` in the two instances needed directly. Having a `kAboutTorHideTorNewsBanner` in the function scope and declared above is confusing and seems not worth it. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27097#comment:26> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs