#27244: Use mmap to hold our cached consensus, when we even need it stored in
RAM
at all.
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: enhancement | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.3.6.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 035-roadmap-master, 035-triaged- | Actual Points:
in-20180711 |
Parent ID: #27243 | Points:
Reviewer: ahf | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by ahf):
* status: needs_review => merge_ready
Comment:
I think these patches looks good. Let's get them merged.
@cyberpunks: Thanks a lot for the work you have put into this ticket (via
#27629). I think your code looks good and I would have accepted this if
there wasn't two implementations that was practically the same.
Let me try to explain a little bit why I ended up picking up the patches
in PR #316 from Nick: When I review code I start out by looking at the
"accumulated diff" (I ignore all the individual commits, but just focus on
what was there before this set of changes vs. what is there after this set
of changes). Once I'm happy with that, I walk over each individual patch
to get an idea about the process on how you got there. In Tor, we very
often use the "fixup" feature of Git for this very reason, so we can
easily spot which things have been changed since last time we reviewed it.
I looked at your changes and Nick changes and Nick's changes was easier
(for me) to follow based on the *commits* themselves. I'm very happy you
helped identifying the issues with the missing `strlen()` calls in Nick's
changes, which was indeed bugs in the code. I hope this won't discourage
you from contributing in the future, since your changes were in fact very
good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27244#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
