#28973: Disable TLS1.3 when openssl bug 7712 is present -------------------------------------------------+------------------------- Reporter: nickm | Owner: nickm Type: defect | Status: | merge_ready Priority: High | Milestone: Tor: | 0.4.0.x-final Component: Core Tor/Tor | Version: Tor: | 0.3.4.9 Severity: Normal | Resolution: Keywords: 033-backport 034-backport | Actual Points: 035-backport | Parent ID: #28616 | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by ahf):
* status: needs_review => merge_ready Comment: Code seems to be called correctly when build against OpenSSL 1.1.1a. The patch looks reasonable to me. Only minor nitpick I spot is to maybe use `bool` as type for `openssl_bug_7712_is_present` - it is not something I have a strong opinion about though. Do you think this ticket should become about removing this bugfix at some point in the future? Having the checks for the `-2` return value as a special case looks a bit funky if seen out of context even with the reference to the OpenSSL bug as a comment. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28973#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs