#29333: Use the bandwidth-file-spec.txt keywords as BandwidthFile attributes ---------------------------+------------------------ Reporter: juga | Owner: atagar Type: defect | Status: new Priority: Medium | Milestone: Component: Core Tor/Stem | Version: Severity: Normal | Resolution: Keywords: tor-bwauth | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: ---------------------------+------------------------
Comment (by juga): As a first step to adapt sbws, i was creating `from_dict` and `to_dict` methods in the sbws class. These are some other things i realized that i'm doing in sbws and/or i think for consistency should probably done differently. - `header` attribute doesn't return timestamp, should it rather return a key `timestamp` and value timestamp? - `measurements` attribute returns a dictionary, should it rather return a list? (the fingerprint is in node_id key) When using `create` (should it have an alias `from_dict`?): - timestamp is not required. Is there a way to pass it? - should the headers be passed in a key `header` to be consistent with `header` attribute? - should `content` be named `measurements` to be consistent with `measurements` attribute? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29333#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs