#29060: shellcheck: test-network.sh issues ----------------------------+------------------------------------ Reporter: rl1987 | Owner: rl1987 Type: defect | Status: needs_revision Priority: Medium | Milestone: Tor: 0.4.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt | Actual Points: Parent ID: | Points: Reviewer: ahf | Sponsor: ----------------------------+------------------------------------ Changes (by ahf):
* status: needs_review => needs_revision Comment: I think these patches looks good with 2 things that we need to figure out. I just asked these questions on IRC as well. 1. bash isn't always located in `/bin/bash` so it might be smarter if we use `/usr/bin/env bash` for the shebang line. On FreeBSD things installed from ports go to `/usr/local/` as prefix. 2. Should we use `.bash` instead of `.sh` for bash scripts? I think yes, but I'm not sure what everyone else thinks here. The second question is a bit more open. Let's fix the first one now and then we can figure out if we should do question 2 as well later :-) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs