#29120: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable -------------------------------------------------+------------------------- Reporter: QZw2aBQoPyuEVXYVlBps | Owner: tbb- | team Type: defect | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-disk-leak, tbb-usability- | Actual Points: website, TorBrowserTeam201902R | Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by mcs): Replying to [comment:27 gk]: > mcs/brade can you have a (second) look on the latest patch? Thanks! The patch looks good to us. We are a little concerned about portions of comment:25, especially the part about `return nullptr;` (because we are do not understand cyperpunks' point). It might be worthwhile to add parens around the second part of the `if` expression; with the patched code, clang emits a `-Wlogical-op- parentheses` warning due to potential confusion when reading the code. The following would be better: {{{ if (aIsPrivateBrowsing || (aContentLength > 0 && aContentLength <= int64_t(MediaPrefs::MediaMemoryCacheMaxSize()) * 1024)) { }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:28> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs