#29221: Tooling to track code-style/best-practices violations --------------------------------------------+------------------------------ Reporter: nickm | Owner: (none) Type: defect | Status: needs_review Priority: Medium | Milestone: Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: network-team-roadmap-2019-Q1Q2 | Actual Points: Parent ID: | Points: 3 Reviewer: nickm | Sponsor: | Sponsor31-can --------------------------------------------+------------------------------ Changes (by asn):
* status: needs_revision => needs_review Comment: Replying to [comment:9 nickm]: > I've made a few comments in the PR. This is generally looking very solid. OK I fixed the easy stuff in a new commit ac05cc7437. I made a ticket #29746 for the rest of good-to-have stuff asked on the PR. In general, some of the good-to-have stuff were not too hard to add, but IMO there should be tests to make sure that they don't influence results. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29221#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs