#25658: Activity 2.1: Improve user understanding and user control by clarifying Tor Browser's security features -------------------------------------------------+------------------------- Reporter: isabela | Owner: | antonela Type: project | Status: | needs_revision Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: ux-team, GeorgKoppen201812, | Actual Points: TorBrowserTeam201903R, tbb-8.5 | Parent ID: | Points: Reviewer: | Sponsor: | Sponsor17 -------------------------------------------------+-------------------------
Comment (by mcs): Thanks for the updated branches. Kathy and I noticed only a few remaining things: securityLevel.js - SecurityLevelStrings: Is it worth it to rely on the getLocale() function from Torbutton? (maybe your answer is "yes") securityLevel.js - SecurityLevelPanel: Remove the comment inside `openAdvancedSecuritySettings()`. securityLevelPanel.css: Please remove the commented out `margin` lines. Regarding the question you asked about how to handle the toolbar icons in an upgrade situation, I don't think there is a simple solution. You probably need to dig through `browser/components/customizableui/CustomizableUI.jsm` and figure out what to do. Hopefully you can do what is needed by using some combination of `addWidgetToArea()`, `removeWidgetFromArea()`, and `moveWidgetWithinArea()`. There is probaly also a way to get the UI to reconfigure itself after the `browser.uiCustomization.state` pref is modified, so you could edit that pref value via code... but we should probably avoid completely resetting everyone's toolbars to the default set of icons. By the way, it will be easier for us to look at what you fixed during a review cycle if you adopt the practice of creating and pushing new branches instead of doing an amend commit followed by a forced push (that way, we can easily compare the old and new branches). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25658#comment:92> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs