#29036: Coverage merge failures cause test_process_slow stderr check to fail -------------------------------------------------+------------------------- Reporter: teor | Owner: teor Type: defect | Status: | needs_revision Priority: High | Milestone: Tor: | 0.4.1.x-final Component: Core Tor/Tor | Version: Tor: | unspecified Severity: Major | Resolution: Keywords: asn-merge, nickm-merge, | Actual Points: 0.6 041-accepted-20190115, regression, tor-ci, | 029-backport, 034-backport, 035-backport, | 040-backport, tor-ci-fail-sometimes | Parent ID: | Points: 0.5 Reviewer: catalyst | Sponsor: -------------------------------------------------+-------------------------
Comment (by teor): Replying to [comment:29 nickm]: > Sorry, I think we need a different target name for this new "reset-gcov" semantics, if that's what we're going for. In the current semantics, running 'reset-gcov' after a test run resets the coverage, but doesn't stop you from running "make check" again. But if we change it to remove the gcno files too, that will means that you need to do a full "make clean" and "make" before you can run the tests for coverage again. I think I understand better now: * we MUST NOT delete gcno files, because they are created when the code is compiled * we MUST delete gcda files to remove the warning (and make our coverage accurate) * we MAY delete gcov files, because they take up space in the cache (and leaving old files around might make our coverage inaccurate) I'll amend that commit to delete gcda and gcov files, but leave gcno files. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29036#comment:30> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs