#28780: circpadding: Add machine flag for not closing circuit if machine is active -------------------------------------------------+------------------------- Reporter: asn | Owner: (none) Type: defect | Status: | needs_revision Priority: Very High | Milestone: Tor: | 0.4.1.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: wtf-pad, tor-relay, tor-cell, | Actual Points: padding, 041-proposed, network-team- | roadmap-2019-Q1Q2 | Parent ID: #28634 | Points: 5 Reviewer: | Sponsor: | Sponsor2 -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_review => needs_revision Comment: Thanks for the help. That was very useful. I rebased your branch on origin/master and added a fixup commit to make it compile and add some more comments (and a useful log): https://github.com/torproject/tor/pull/933 I agree with https://github.com/torproject/tor/pull/644/commits/f31a2810b589866af3834fcb25639f10b549ea4c but instead of removing that test line, could we use `circuit_expire_old_circuits_clientside()` in the test to demonstrate that it closes it? Also, a changes file is needed. Also perhaps the commit structure can be split a bit better (add purpose, add function, add tests). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28780#comment:24> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs