#27609: TBA: Evaluate Tor Onion Proxy Library -------------------------------------------------+------------------------- Reporter: sysrqb | Owner: tbb- | team Type: defect | Status: | needs_revision Priority: Very High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-mobile, tbb-8.5-must, | Actual Points: TorBrowserTeam201904 | Parent ID: | Points: Reviewer: | Sponsor: | Sponsor8 -------------------------------------------------+-------------------------
Comment (by sisbell): Replying to [comment:62 sysrqb]: > Replying to [comment:60 eighthave]: > > In my experience, it is generally a lot smoother to do these kinds of file management activities before everything gets packaged into the APK. There are lots of little hacks in the final packaging steps to support zipaligning, zeroing out timestamps, v1 signatures and v2/v3 signatures, etc. So by manipulating the APK, it'll make all those steps harder to deal with. > > > > For example, this could be done by a gradle Task that is called after compile or maybe as the first step of packaging. > > I wonder if we can build a single aar for this (where it includes all the libs), and then make copies of it and tweak each copy so it is arch- specific and only includes the needed binaries. Then we only inject the correct arch-specific aar into the firefox build stage. I'll open another ticket for this. The dependent aars include all architectures. So we aren't filtering in tor-onion-proxy-library, tor-android-service. Filtering is only occurring in tor-browser on master (although it would be best if we could filter at the firefox stage). > > I opened #30199 for other review comments on tor-android-service. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27609#comment:64> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs