#30206: Segfault in proxy-go -----------------------------------+-------------------------------- Reporter: irl | Owner: cohosh Type: defect | Status: needs_revision Priority: Medium | Milestone: Component: Obfuscation/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------------+-------------------------------- Changes (by cohosh):
* status: accepted => needs_revision Comment: Here's a fix: https://github.com/cohosh/snowflake/compare/ticket30206 The proxy-go instances were seg faulting occasionally in cases where the client successfully made a data channel connection but the data channel was closed before the timeout occurred. I added a second channel that will trigger when the data channel has been successfully opened (and therefore pc.Destroy() is handled by dataChannelHandler), and only destroy the connection if this channel has not been closed before the Timeout (which I've shortened to a more realistic time). I'm going to patch our deployed proxy-go instances immediately, but wait to merge until this has been reviewed. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30206#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs