#30217: Extend CollecTor filesystem protocol for bandwidth files
-------------------------------------------------+-------------------------
Reporter: irl | Owner: irl
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: tor-bwauth,tor-dirauth,metrics- | Actual Points:
roadmap-2019-q2 |
Parent ID: #21378 | Points:
Reviewer: karsten | Sponsor:
-------------------------------------------------+-------------------------
Comment (by karsten):
Replying to [comment:7 irl]:
> Please review this commit:
>
>
https://gitweb.torproject.org/user/irl/collector.git/commit/?h=task/30217&id=19ae66a1314f9b1b4fa5d8019908971169a06599
Will take a look after the lunch break. Quick question before that:
> The only change here is preferring to use the "file_created" timestamp
instead of the "timestamp" when it is available.
I can see how this is easier to comprehend for bandwidth files created by
sbws. But when using a mix of files created by torflow and sbws, this
might be confusing to users. I don't feel as strongly about this, but I
want to point out that this is a possible source of confusion. What do you
think?
Using "bandwidth" instead of "bandwidth-file" is fine.
I'll review the diff after my break.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30217#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
