#12631: Tor Browser for ARM architecture
--------------------------------------------+------------------------
Reporter: mttp | Owner: (none)
Type: project | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201904R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------
Comment (by gk):
Replying to [comment:26 JeremyRand]:
> (My current code is still at https://notabug.org/JeremyRand/tor-
browser-build/src/armhf-esr60 (the armhf-esr60 branch); and docs are still
at https://wiki.raptorcs.com/wiki/Porting/Tor_Browser .)
I skimmed the changes on the branch, nice work! A couple of high-level
comments:
1) We should start to get the compiler related things right. I don't
understand why you need to add a `gcc-cross` project in addition to the
`gcc` project. Cross-compiling GCC so it is usable for a given target
should just get included in the `gcc` project both in its `config` and
`build` file I think.
2) Why do we have a `var/linux-cross` + a `var/linux-arm` target? It seems
it would be worthwhile to stick to the OS-arch pattern and if we think we
want to generate a more abstract target later on that's easily doable
(like we have e.g. `var/linux` and `var/linux-x86_64` defined already to
have the option to apply general things to all the Linux arches and have
arch-specific things, though)
3) Allowing networking during the build part does not fly. What are the
needs for that?
4) FTE is going away soon, just ignore it (and set the `fteproxy` switch
in `rbm.conf` in the meantime). It's fine to ignore snowflake for now,
too. There is a `snowflake` switch you can set in `rbm.conf` as well.
5) Could you clean up your patches substantially and reorder them, so that
you maybe have patches per project? It's hard to give more fine-grained
feedback otherwise.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12631#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
