#30551: Android - Use different port numbers
--------------------------------------+--------------------------
Reporter: sysrqb | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------
Comment (by sysrqb):
Replying to [comment:1 sisbell]:
> These values are the ones defined by Orbot but we can override them for
torbrowser.
>
> We can extend AndroidTorSettings (say BrowserTorSettings) and override
transPort(), getHttpTunnelPort(), dnsPort() to all return null. This will
remove them from the generated torrc file so there will not be any
conflict.
>
> Then in TorService.onCreate(), we detect if the package name is
torbrowser and if so use BrowserTorSettings rather than AndroidSettings.
>
Hmmm, okay, I'll look into this. Thanks! We'll be sad if we must special
case it based on package name (we have three different packages right now,
`torbrowser`, `torbrowser_alpha`, `torbrowser_nightly`). And other apps
may want this capability too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30551#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
