#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 034-triage-20180328, | Actual Points:
034-removed-20180328 |
Parent ID: | Points: 1
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
I did a review on this code.
Thanks for the improvements and fixes.
But this code still contains quite a few logic errors and memory safety
issues.
Here's how you can help us do faster reviews of your code:
* Don't force-push. When you force-push, we have to review the whole
branch again.
* Instead, add new commits that fix the issues from the review.
* For each comment in the review, reply with the commit hash of the new
commit that fixes the issue.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:50>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
