#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it -------------------------------------------------+------------------------- Reporter: Rezonansowy | Owner: tbb- | team Type: defect | Status: | needs_revision Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: AffectsTails, tbb-parity, | Actual Points: TorBrowserTeam201905, GeorgKoppen201905, ux- | team | Parent ID: #24855 | Points: Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by acat): With respect to strings that are duplicated in torbutton *.properties and *.dtd (see comment https://trac.torproject.org/projects/tor/ticket/30464#comment:1), I first thought that we could maybe start migrating the duplicated properties to Fluent, which should not have the duplication issue since it would all be in *.ftl files. However, it's unclear to me how to easily achieve in Fluent the same "multi-locale" builds that we decided to do for tor- launcher and torbutton integration (all locales are shipped in the build). I think a more pragmatic approach for now is to remove the duplicated strings from *.properties and have them only in the DTDs. Using DOMParser, we can programatically translate strings in privileged JS in a similar way as we do now for *.properties files (see `localizeEntity` from https://gitweb.torproject.org/tor- browser.git/tree/testing/marionette/l10n.js?h=tor- browser-60.7.0esr-9.0-1#n46). While this is not ideal, I think it would be a good enough solution until we decide to migrate to Fluent. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:48> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs