#30733: SBWS does not detect changes in descriptor bandwidth values -----------------------------------+----------------------------------- Reporter: starlight | Owner: (none) Type: defect | Status: new Priority: Very High | Milestone: sbws: 1.1.x-final Component: Core Tor/sbws | Version: sbws: 1.1.0 Severity: Critical | Resolution: Keywords: sbws-majority-blocker | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------------+-----------------------------------
Comment (by juga): I realized we don't have these options: https://stem.torproject.org/tutorials/mirror_mirror_on_the_wall.html#can-i -get-descriptors-from-the-tor-process Looking at the log, found it was removed in version 0.1.1 and never added again: https://github.com/torproject/sbws/commit/816591fa67593d74d4facc63ed202a9cd1cf0d99. I was quite surprised since we talked about the options several times, so searched for tickets and i didn't find anywhere were we said to remove them: https://github.com/torproject/sbws/issues/146#issuecomment-385974474, https://github.com/torproject/sbws/pull/147#discussion_r185492495, https://github.com/torproject/sbws/issues/144, https://trac.torproject.org/projects/tor/timeline?from=2018-05-02T01%3A56%3A25Z&precision=second. The way i have work so far is: - implement the patch and the tests, but this is hard to test with the current test network we have - create PR and set to review - wait to get it review - release a new version - update debian package - install the new package in production when it's available (and announce we'll use new version) - then finally we can see if the patch is working So, because it's a long process, i'm just going to add those options to longclaw's sbws, wait ~3 days (the time it takes to measure the whole network) and check if some descriptors' bandwidth changed. If the descriptors bandwidth change, cool, it worked and i'll create the PR. If not, then i'll comment it and try to figure out what else is wrong. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs